Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add field exclusion strategy for SnippetController #7287

Merged
merged 7 commits into from
Mar 29, 2024

Conversation

mamazu
Copy link
Contributor

@mamazu mamazu commented Feb 15, 2024

Q A
Bug fix? yes
New feature? no
BC breaks? yes
Deprecations? no
Fixed tickets fixes #7023
Related issues/PRs #7023
License MIT
Documentation PR -

What's in this PR?

Adding code to only serialize fields specified in the request of the snippet controller.

Why?

When using the snippet listing by default it also serializes the content which is very slow. This PR adds an exclusion strategy that will not serialize the content anymore.

To Do

  • Add breaking changes to UPGRADE.md

@mamazu mamazu force-pushed the field_exclusion branch 3 times, most recently from 6a1578f to 2973375 Compare February 16, 2024 11:25
@mamazu
Copy link
Contributor Author

mamazu commented Mar 23, 2024

@alexander-schranz Do you think we can also get this shipped in 2.6 maybe?

@alexander-schranz alexander-schranz added the Feature New functionality not yet included in Sulu label Mar 29, 2024
@alexander-schranz alexander-schranz enabled auto-merge (squash) March 29, 2024 08:09
@alexander-schranz alexander-schranz merged commit 17662b6 into sulu:2.6 Mar 29, 2024
8 checks passed
@mamazu mamazu deleted the field_exclusion branch March 29, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New functionality not yet included in Sulu
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants