Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add phpcr cleanup command #7291

Merged
merged 14 commits into from
Mar 15, 2024

Conversation

wachterjohannes
Copy link
Member

@wachterjohannes wachterjohannes commented Feb 21, 2024

Q A
Bug fix? no yes
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets none
Related issues/PRs replaces #7043
License MIT
Documentation PR sulu/sulu-docs#791

What's in this PR?

This PR add a new command sulu:phpcr:cleanup to cleanup the phpcr repository.

Why?

This is needed to keep the repository clean.

Example Usage

bin/console sulu:phpcr:cleanup --force

To Do

  • Create a documentation PR
  • Use also publish event and the live session to cleanup the live node
  • Test with different languages, blocks and image_maps
  • Test with audience-targeting and segmentation
  • Refactor to use StreamOutput with a file handle
  • Guard the node with:
  • Add summary of the cleanup (stats and ignored nodes) to the debug-file at the top
  • Feedback from @mamazu

@wachterjohannes wachterjohannes force-pushed the feature/phpcr-cleanup branch 4 times, most recently from 384be8d to 5504e84 Compare March 14, 2024 15:31
@wachterjohannes wachterjohannes self-assigned this Mar 14, 2024
@wachterjohannes wachterjohannes marked this pull request as ready for review March 14, 2024 15:34
@alexander-schranz alexander-schranz added the Feature New functionality not yet included in Sulu label Mar 14, 2024
@alexander-schranz alexander-schranz merged commit 29088d8 into sulu:2.6 Mar 15, 2024
8 checks passed
@mamazu
Copy link
Contributor

mamazu commented Mar 15, 2024

🎉

@wachterjohannes wachterjohannes deleted the feature/phpcr-cleanup branch March 15, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New functionality not yet included in Sulu
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants