Add last modified field value to sitemap when exists #7313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinlagler
force-pushed
the
feature/last-modified-sitemap
branch
from
294a86c
to
44d8d5e
Compare
| @@ -126,7 +126,7 @@ private function generateSitemapUrl( | |||
| string $host, | |||
| string $scheme | |||
| ) { | |||
| $changed = $contentPage['changed']; | |||
| $changed = $contentPage['lastModified'] ?? $contentPage['changed']; | |||
There was a problem hiding this comment.
@chirimoya is the new expected behaviour not returning the created instead of changed date of the node? Should we remove the fallback to changed? It is a little bit strange here now. As soon as once the lastModified is defined the changed is not longer automatically provided to the sitemap, is that expected?
There was a problem hiding this comment.
As discussed with @chirimoya to avoid a backwards compatibility break we will keep here the fallback to changed like currently ipmlemented. We maybe will change this in future when it is maybe possible in the UI of the publishing to set update lastmodified timestamp via a toggler.
alexander-schranz
changed the title
alexander-schranz
requested changes
Mar 18, 2024
martinlagler
force-pushed
the
feature/last-modified-sitemap
branch
from
44d8d5e
to
a3bdd2b
Compare
martinlagler
force-pushed
the
feature/last-modified-sitemap
branch
from
a3bdd2b
to
619d259
Compare
alexander-schranz
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Adding the last modified field to the sitemap if it's defined.
Why?
For better content in the sitemap.