Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade css loader package and use webpack assets modules #7329

Merged

Conversation

alexander-schranz
Copy link
Member

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets fixes part of #6343
Related issues/PRs #
License MIT
Documentation PR sulu/sulu-docs#

What's in this PR?

Upgrade css loader package and use webpack assets modules.

Why?

No longer require to file-loader or raw-loader packages. Use uptodate packages.

Currently sadly the CKEditor build is not working with this setup. Wait for feedback from them following issue if they want also migrate there build to new webpack assets modules: ckeditor/ckeditor5#12979

Bildschirmfoto 2022-12-07 um 00 01 13

Current error:

CKEditorError: e is null
Read more: https://ckeditor.com/docs/ckeditor5/latest/support/error-codes.html#error-e is null
_updateXMLContent iconview.js:96
render iconview.js:58

Latest test I get error with icon font did not have a deep look into it:

Bildschirmfoto 2024-03-25 um 17 15 25

@alexander-schranz alexander-schranz marked this pull request as ready for review March 25, 2024 17:17
@alexander-schranz alexander-schranz added the DX Affecting the end developer label Mar 25, 2024
@alexander-schranz alexander-schranz merged commit e87799d into sulu:2.6 Mar 25, 2024
8 checks passed
@alexander-schranz alexander-schranz deleted the feature/upgrade-css-loader branch March 25, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX Affecting the end developer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant