Tests should crash on non zero exit code

[mamazu]

Q	A
Bug fix?	no
New feature?	no
BC breaks?	no
Deprecations?	no
Fixed tickets	-
Related issues/PRs	#6834
License	MIT
Documentation PR	-

What's in this PR?

This adds the function that the tests crash when one of the steps exists with a non-zero exit code.

Why?

Currently the tests just ignore the exit code and continue running which then causes issues further down the suite. This should make the tests easier to debug as the errors are reported earlier and closer to the source.

[alexander-schranz]

Currently the tests just ignore the exit code and continue running which then causes issues further down the suite.

This is the expected behaviour of the runtests script. We run always all scripts and not exit directly when there is an error in one of the scripts. Else we don't have all errors in the CI for all bundles.

[mamazu]

Okay the problem I was encountering in this case is the test shouldn't run if the init step fails (see the jackalope 2 merge request).

[mamazu]

And the test cases in this case aren't affected because they are allowed to fail, their failure is recorded and just passed on.

[alexander-schranz]

I see I would update the init_dbal part to throw exception there if the process for schema update finish with a none zero exit code.

[alexander-schranz]

Something like:

    $process = exec_sf_cmd(
        'doctrine:schema:update --force'
    );
    
    if (0 !== $process->getExitCode()) {
        // error already outputted before via write_error

        exit($process->getExitCode());
    }

[mamazu]

That's also acceptable.

[alexander-schranz]

We should target the 2.4 for this change.

[mamazu]

Changed the base.

[alexander-schranz]

we should not exit when one bundle fails to init.

the other bundle tests should still be executed.

[alexander-schranz]

I think we don't need to catch this. Aslong as the tests run as expected it is not required that a bundle uses the document manager bundle.

[mamazu]

I wanted to catch this: https://github.com/sulu/sulu/actions/runs/8525431456/job/23352362111?pr=6834

The Init Task is successful although the update of the schema failed. Without this none of the tests will work.

[alexander-schranz]

That error would still be catched we just don't should exit on the init_bundle part.

[mamazu]

Looks good can you apply those and merge because the app doesn't support that.