Fix copy shadow properties #7343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-schranz
added
the
Bug
wachterjohannes
force-pushed
the
fix-copy-shadow-properties
branch
9 times, most recently
from
ca4e17b
to
dd3f8f4
Compare
wachterjohannes
force-pushed
the
fix-copy-shadow-properties
branch
from
73806ad
to
e022b9e
Compare
alexander-schranz
requested changes
Apr 8, 2024
src/Sulu/Bundle/PageBundle/Resources/phpcr-migrations/Version202404051700.php
Outdated
Show resolved
Hide resolved
src/Sulu/Bundle/PageBundle/Resources/phpcr-migrations/Version202404051700.php
Outdated
Show resolved
Hide resolved
src/Sulu/Bundle/PageBundle/Resources/phpcr-migrations/Version202404051700.php
Show resolved
Hide resolved
wachterjohannes
force-pushed
the
fix-copy-shadow-properties
branch
2 times, most recently
from
721a348
to
4490c4c
Compare
wachterjohannes
force-pushed
the
fix-copy-shadow-properties
branch
from
4490c4c
to
7d45eb9
Compare
Co-authored-by: Alexander Schranz <alexander@sulu.io>
wachterjohannes
force-pushed
the
fix-copy-shadow-properties
branch
from
7d45eb9
to
764871d
Compare
alexander-schranz
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This PR fixes the handling of shadow data. Some fields are copied to the shadow but until now not all which are needed and also not in the right priority