Upgrade Phpunit (part 1) #7344
Upgrade Phpunit (part 1) #7344
Conversation
|
|
||
| $this->assertObjectHasAttribute('logo', $form); | ||
| $this->assertObjectHasAttribute('account', $form); | ||
| $response = \json_decode($this->client->getResponse()->getContent(), true); |
There was a problem hiding this comment.
Going for array deserialization would make it easier in some places, as we can just compare arrays.
| @@ -59,7 +59,7 @@ class MediaDataProviderRepositoryTest extends SuluTestCase | |||
| /** | |||
| * @var array | |||
| */ | |||
| private $mediaData = [ | |||
| private static $mediaData = [ | |||
There was a problem hiding this comment.
This data is static and doesn't need to live on the test. Helpful for making the dataproviders static later.
| * Class AbstractScaleTest. | ||
| */ | ||
| abstract class AbstractTransformationTest extends SuluTestCase | ||
| abstract class AbstractTransformation extends SuluTestCase |
There was a problem hiding this comment.
Renaming the test as it otherwise will be picked up as a test but can't be instantiated as a test.
| $this->client->getContainer()->get('event_dispatcher')->addListener( | ||
| 'sulu.tag.delete', | ||
| [$mockedEventListener, 'onDelete'] | ||
| ); |
There was a problem hiding this comment.
The way to check if this method is called can be simplified by just passing a closure and setting a variable inside to true. That way we don't need to create a mock object.
|
|
||
| namespace Sulu\Component\Rest\Tests\Unit; | ||
|
|
||
| interface MockInterface |
There was a problem hiding this comment.
This class was used in the RestHelperTest. Phpunit 10 will not allow to Mock classes that don't exist so, just created this interface to use it in mocking.
| $mockedObject = $this->createConfiguredMock(MockInterface::class, [ | ||
| 'getId' => 1, | ||
| 'getValue' => 2, | ||
| ]); |
There was a problem hiding this comment.
Could be reverted but it's the same as above just shorter.
| return [ | ||
| [\stdClass::class, false], | ||
| [\get_class($securedEntity->reveal()), true], | ||
| [SecuredEntityInterface::class, true], |
There was a problem hiding this comment.
Why create a mock when we just need the class of it?
|
@mamazu Thank you! |
What's in this PR?
assertObjectHasAttributeWhy?
Having it in the bigger #7339 PR makes it hard.