Preview update on extensions (Seo / Excerpt) changes #7352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alexander-schranz @wachterjohannes should we merge this to 2.4 or 2.6? |
|
@Prokyonn would say 2.4 |
alexander-schranz
added
the
Bug
Prokyonn
force-pushed
the
enhancement/excerpt-preview-update
branch
from
4b7e0bc
to
f357c76
Compare
Co-authored-by: Alexander Schranz <alexander@sulu.io>
Prokyonn
force-pushed
the
enhancement/excerpt-preview-update
branch
from
a204006
to
4aa6c52
Compare
|
@alexander-schranz @Prokyonn May be do the same fix in ArticleObjectProvider.php in the ArticleBundle ? |
|
@Olivier127 thx for the hint do you want to create a pull request for it? |
|
@alexander-schranz I have tried, but i'm not allowed to create any branch on ArticleBundle. |
|
You have to fork the repository and create a pull request from your repository to the repository in the sulu namespace. |
|
@mamazu thanks. My PR : sulu/SuluArticleBundle#676 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Adds updates to the page preview when seo/excerpt fields are changed
Why?
#7348