Fix prepend website cache class with preview #7356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sauls
changed the title
sauls
force-pushed
the
feature/preview-kernel-webspace-registration
branch
from
dc20d51
to
5c19425
Compare
|
@sauls Thx for the pull request. Can you target the 2.4 branch and rebase the pull request to 2.4: git checkout your-branch
git remote add sulu git@github.com:sulu/sulu.git
git fetch sulu
git rebase -i sulu/2.5 --onto sulu/2.4
git push --force |
sauls
force-pushed
the
feature/preview-kernel-webspace-registration
branch
from
5c19425
to
2dfa38c
Compare
|
@alexander-schranz I guess I did it right. |
...dle/Infrastructure/Symfony/DependencyInjection/Compiler/RegisterPreviewWebspaceClassPass.php
Outdated
Show resolved
Hide resolved
alexander-schranz
added
the
Bug
alexander-schranz
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Fix for #7332 , don't know if this is the right way. Additionally tried to run tests locally but had issues with db connection, did not looked deeper, did only unit test, but I guess functional test would make more sense. Additionally this bundle has dependency from core_bundle, so in tests somehow we need to put that, so I don't know if in monorepo cross dependency declaration is valid. @alexander-schranz