Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add language package for ckeditor #7367

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

martinlagler
Copy link
Contributor

@martinlagler martinlagler commented Apr 15, 2024

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Related issues/PRs #7363
License MIT
Documentation PR sulu/sulu-docs#

What's in this PR?

Add ckeditor language plugin package. https://ckeditor.com/docs/ckeditor5/latest/features/language.html

Why?

So it's possible to add the language plugin to your editor toolbar, for better accessability.

@alexander-schranz alexander-schranz added Feature New functionality not yet included in Sulu Design required For this issue a design form our UX expert is required labels Apr 15, 2024
@alexander-schranz
Copy link
Member

Installing the plugin does currently not hurt. We still need to check how we show the [lang=de] attribute for the user the CKEDitor solution I don't find has a good UX here as you need to click in the text and have that menu open to edit it.

@alexander-schranz alexander-schranz merged commit 1acf2cb into sulu:2.6 Apr 15, 2024
8 checks passed
@alexander-schranz alexander-schranz removed the Design required For this issue a design form our UX expert is required label Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New functionality not yet included in Sulu
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants