Fix condition provider crashing of the admin when no parent is found #7379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prokyonn
commented
Apr 24, 2024
...minBundle/Resources/js/containers/Form/conditionDataProviders/parentConditionDataProvider.js
Show resolved
Hide resolved
alexander-schranz
requested changes
Apr 24, 2024
...minBundle/Resources/js/containers/Form/conditionDataProviders/parentConditionDataProvider.js
Show resolved
Hide resolved
alexander-schranz
added
the
Bug
|
A test would be nice to be added to avoid regression in the future. |
Prokyonn
force-pushed
the
bugfix/parent-condition-data-provider
branch
from
8b959b5
to
d7950e1
Compare
alexander-schranz
changed the title
alexander-schranz
approved these changes
Apr 24, 2024
|
@alexander-schranz added a test and rebased to 2.4 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
When adding a new block the
settingsarray is undefined, this MR prevents the admin from completely crashing in this case.Why?
Admin ui should never crash completely due to JS errors