-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove SymfonyTestsListener configuration #7432
Remove SymfonyTestsListener configuration #7432
Conversation
38f4858
to
ad66436
Compare
Why do the tests break when I change the XML? |
@mamazu I don't know maybe some tests relay on some functionality of the bridge: https://symfony.com/doc/current/components/phpunit_bridge.html. But as a I know there should be for all things a replacement in PHPUnit itself or a way to workaround it https://thephp.cc/presentations/phpunit-10-for-symfony-developers Lets check if we can change the two tests to work again on 2.5 without the listener. |
It looks like the problem is "perserveGlobalState". This should be off for isolated processes anyways (see: sebastianbergmann/phpunit#3954) which is probably why it runs in phpunit 10. So what to do:
But I'm open for suggestions. The line that is currently fixing that is here: |
@mamazu if I understand correctly adding |
Oh yeah that would be too easy. :D Did it like that. |
@mamazu Thank you! |
What's in this PR?
Removing SymfonyTestsLister since it's being removed in PhpUnit 10 anyways.
Why?
see above