Fix Truncate component on window load #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The truncate component does not always calculate correctly since sometimes we need to wait for the JS to load to get correct font position/size/... This PR adds a trigger on load to prevent these issues.
|
This additional event listener definitely doesn't hurt anyone, therefore I'm fine with merging this. But I don't think it fully fixes your issue, because the |
|
@luca-rath i dont know if the font loading was the issue back then. if we can catch most other issues with the load listener thats fine for now and if we run in to any more problems we can still try to fix them later on. |
luca-rath
approved these changes
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The truncate component does not always calculate correctly since sometimes we need to wait for the JS to load to get correct font position/size/... This PR adds a trigger on load to prevent these issues.