Add EditorExtension #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-schranz
force-pushed
the
feature/editor-twig-extension
branch
3 times, most recently
from
408eec8
to
73f60ad
Compare
|
Failing tests has nothing todo with this PR the IntlExtension doesn't work like expected see: symfony/symfony#35309. Fixed in #22 |
| { | ||
| return [ | ||
| new TwigFilter('editor', [$this, 'editor'], ['is_safe' => ['html']]), | ||
| new TwigFilter('editor_classes', [$this, 'editorClasses'], ['is_safe' => ['html']]), |
There was a problem hiding this comment.
Better naming suggestions welcome. /cc @luca-rath @thomasduenser @Quehnie @marcostastny @mfehr94 @mscharl @sabinebaer ...
alexander-schranz
force-pushed
the
feature/editor-twig-extension
branch
from
73f60ad
to
de68e12
Compare
luca-rath
suggested changes
Jan 12, 2020
|
@alexander-schranz what do you think of something like symfony's |
|
@luca-rath would be interesting but sadly not sure how the |
alexander-schranz
force-pushed
the
feature/editor-twig-extension
branch
from
e6d4655
to
619b1a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will add a
editorandeditor_classestwig filter.editor
Will wrap the given html with a div with a specific class.
editor_classes
Will add classes to specific tags.