Rename register component twig function to prepare #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-schranz
force-pushed
the
enhancement/rename-register-component-to-prepare-component
branch
2 times, most recently
from
b1b23af
to
32e3487
Compare
alexander-schranz
force-pushed
the
enhancement/rename-register-component-to-prepare-component
branch
from
32e3487
to
86d90bb
Compare
alexander-schranz
force-pushed
the
enhancement/rename-register-component-to-prepare-component
branch
from
86d90bb
to
d185d1a
Compare
| @@ -30,7 +30,7 @@ public function setUp(): void | |||
|
|
|||
| public function testRegisterComponent(): void | |||
There was a problem hiding this comment.
maybe adjust test names?
There was a problem hiding this comment.
Good catch did update them 👍
Co-authored-by: nnatter <niklas.natter@gmail.com>
Co-authored-by: nnatter <niklas.natter@gmail.com>
Co-authored-by: nnatter <niklas.natter@gmail.com>
Co-authored-by: nnatter <niklas.natter@gmail.com>
Co-authored-by: nnatter <niklas.natter@gmail.com>
niklasnatter
approved these changes
Feb 25, 2021
alexander-schranz
deleted the
enhancement/rename-register-component-to-prepare-component
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29
This will rename the following functions
register_component->prepare_componentcall_service->prepare_service