-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to guess and calculate width and height for an image format #36
Merged
niklasnatter
merged 7 commits into
sulu:master
from
alexander-schranz:feature/image-guess-width-height
Sep 17, 2021
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
be26c58
Guess width and height by given image format
alexander-schranz 214f499
Add option to guess and calculate width and height for an image format
alexander-schranz 46ffccf
Fix phsptan
alexander-schranz dce9bb3
Implement aspect ration with image configuration
alexander-schranz 0b5fa50
Apply suggestions from code review
alexander-schranz cf8e108
Fix phpstan
alexander-schranz b49ea6c
Update docs/image.md
alexander-schranz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
accessing the
%sulu_media.image.formats%
parameter would allow us to not rely on the format key here. but i understand that it makes the method dependent on sulu.another possibility would be trying to access the
%sulu_media.image.formats%
parameter and fallback to this implementation if it is not available.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i dont have a lot of experience with this package and i am not sure if anything sulu related is accessed somewhere else. if yes, i think it would be nice to use
%sulu_media.image.formats%
. if not, we should probably not start doing it 🙂There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently the web twig extension has no sulu dependencies and so are sulu independent. As
sulu_media.image.formats
is no service just an array configuration which we could reuse without a dependency to sulu.I'm fine to add
imageFormatsConfiguration
as parameter and use it when is configured and else fallback to it. What do you think?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think it would be nice to do that, because the feature would not depend on the format of the keys then 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did update the extension!