Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mulit page view #4182

Merged
merged 1 commit into from
Apr 13, 2024
Merged

Conversation

changlichun
Copy link
Collaborator

#246 #776 #1171

I tried to implement this with minimal modifications. I use zoomlevel to control the column number. I got it to be able to barely run, is there any more testing anyone can provide?

@kjk kjk changed the base branch from master to multi-column April 13, 2024 13:36
@kjk kjk merged commit 78aa745 into sumatrapdfreader:multi-column Apr 13, 2024
1 check passed
@kjk
Copy link
Member

kjk commented Apr 13, 2024

Thanks.

This is a bigger item that requires some thought regarding the UI.

To make it possible for both of us to work on the same code, I created branch multi-column and merged this PR there.

I've given you rights to checkin into this repository so please do further work on multi-column branch directly. (also if you make future contributions, feel free to create a branch in this repository; this makes it easier for me to test / tweak the code).

I've opened #4184 to track this work with my preliminary thoughts about UI.

@changlichun changlichun deleted the Mulit-page-view branch April 13, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants