Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Python 2 compatibility code #21

Merged
merged 1 commit into from
Jan 24, 2023
Merged

Conversation

kurtmckee
Copy link
Contributor

As a side effect, the code coverage of unit tests is now 100%.

As a side effect, the code coverage of unit tests is now 100%.
@google-cla
Copy link

google-cla bot commented Jan 23, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@kurtmckee
Copy link
Contributor Author

Signed the Google CLA. Thanks for reviewing this PR!

I'm using this package in a project I'm working on, and I'm hopeful to add a few additional tests after this merges (specifically, I'd like to use Hypothesis to test the round-tripping functionality, as it is excellent at finding round-trip issues).

Copy link
Owner

@suminb suminb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Appreciate it!

@suminb
Copy link
Owner

suminb commented Jan 24, 2023

I'll merge and publish this as v0.6.0 as soon as possible. Thanks for your PR!

@suminb suminb merged commit 0fad7ea into suminb:develop Jan 24, 2023
@kurtmckee kurtmckee deleted the rm-py2-code branch January 24, 2023 23:24
@kurtmckee
Copy link
Contributor Author

You're welcome! Thanks for your work on base62!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants