Fetch daily data

suminb · Jan 10, 2018 · 87d69af · 87d69af
1 parent 88cca3f
commit 87d69af
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 8 deletions.
diff --git a/finance/providers/yahoo.py b/finance/providers/yahoo.py
@@ -1,6 +1,5 @@
 import json
 
-from bs4 import BeautifulSoup
 import requests
 
 from finance.models import Granularity
@@ -28,8 +27,8 @@ def get_url(self, symbol):
     def asset_values(self, symbol, start_time, end_time,
                      granularity=Granularity.day):
         mappings = {
-            Granularity.day: self.fetch_data_for_day,
-            Granularity.min: self.fetch_data_for_minute,
+            Granularity.day: self.fetch_daily_data,
+            Granularity.min: self.fetch_data_by_minutes,
         }
 
         try:
@@ -39,10 +38,26 @@ def asset_values(self, symbol, start_time, end_time,
 
         return self.filter_empty_rows(rows)
 
-    def fetch_data_for_day(self, symbol, start_time, end_time):
-        raise NotImplementedError
+    # NOTE: 'Data by day' would keep the name consistent, but 'daily data'
+    # sounds more natural.
+    def fetch_daily_data(self, symbol, start_time, end_time):
+        url = self.get_url(symbol)
+
+        params = {
+            'symbol': symbol,
+            'period1': int(start_time.timestamp()),
+            'period2': int(end_time.timestamp()),
+            'interval': '1d',
+            'includePrePost': 'true',
+            'events': 'div%7Csplit%7Cearn',
+            'corsDomain': 'finance.yahoo.com',
+        }
+        resp = requests.get(url, params=params)
+        rows = self.parse_chart_data(resp.text)
+
+        return rows
 
-    def fetch_data_for_minute(self, symbol, start_time, end_time):
+    def fetch_data_by_minutes(self, symbol, start_time, end_time):
         url = self.get_url(symbol)
 
         params = {

diff --git a/tests/test_providers.py b/tests/test_providers.py
@@ -183,12 +183,12 @@ def test_miraeasset_transactions(param):
             assert record.currency in ['KRW', 'USD']
 
 
-def test_yahoo_provider():
+@pytest.mark.parametrize('granularity', [Granularity.min, Granularity.day])
+def test_yahoo_provider(granularity):
     provider = Yahoo()
     symbol = 'MSFT'
     start_time = datetime.combine(parse_date(-7), time(0))
     end_time = datetime.utcnow()
-    granularity = Granularity.min
     asset_values = \
         provider.asset_values(symbol, start_time, end_time, granularity)
     flag = False