Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazily import implementations #14

Merged
merged 1 commit into from
Jan 17, 2021

Conversation

dahlia
Copy link
Collaborator

@dahlia dahlia commented Jan 16, 2021

This fixes ImportError that setup.py throws:

$ python setup.py 
Traceback (most recent call last):
  File "setup.py", line 6, in <module>
    import hanja
  File "hanja/__init__.py", line 8, in <module>
    from hanja.impl import is_hanja, is_valid_mode, split_hanja, translate
  File "hanja/impl.py", line 5, in <module>
    from hanja.table import hanja_table
  File "hanja/table.py", line 2, in <module>
    import yaml
ImportError: No module named yaml

@google-cla
Copy link

google-cla bot commented Jan 16, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

google-cla bot commented Jan 16, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@dahlia
Copy link
Collaborator Author

dahlia commented Jan 16, 2021

@googlebot I signed it!

@coveralls
Copy link

coveralls commented Jan 16, 2021

Coverage Status

Coverage increased (+0.7%) to 93.846% when pulling 5c1a3c2 on dahlia:make-setup.py-independent into e1ec45b on suminb:develop.

@dahlia
Copy link
Collaborator Author

dahlia commented Jan 16, 2021

A build job (pypy) failed because the cryptography package was failed to be installed. I believe the job fail is irrelevant to this pull request. Other build jobs all succeeded.

dahlia added a commit to dahlia/cjk-compsci-terms that referenced this pull request Jan 16, 2021
This fixes setup.py throwing ImportError.
@suminb suminb merged commit 6ccbb20 into suminb:develop Jan 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants