This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
Btc view #158
Merged
Btc view #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added honey bunches of docs * fixed doc errors * fixed stuff * removed todo, edited some docs
* first test * more tests, cleaned up BTCUtils.test.js * wrong function * added more tests * cleaned up file, added more tests * feature: hex encoded errors for typedmemview * fixed opReturnPayload test, added scriptPubkey function in ViewBTCtest.sol * tests: indexVin and indexVout - fix indexVin & indexVout - fix tryAsVin & tryAsVout - fancy hex errors in typedmemview - add tests for indexing vin/vout - remove vectors for non-minimal varints in vin/vout - misc cleanup to truffle config - linting - type to uint conversion comments * refactor: improve/fix nibbleHex * finished nasty verifyHash256Merkle function test * tests: Tests and bugfixes for ViewSPV * added notes * moved type conversion and validation to ViewSPVTest.sol * accidentally reverted change * added more type assertions * notes on tryAsVout test * lint: solidity assembly * feature: error message for non-minimal varints * added new errors for Non-minimal varints * refactor: improve non-minimal varint error * bug: don't be so lazy * fixed test cases that deal with non-minimal var ints * updated error tests, needs cleaned up * pushing latest * fixed bugs * finished payload, work and workHash tests * separated out error cases * Organized ViewBTC tests * updated test descriptions * bug: fix payload p2sh path * added test case to extractHash * chore: improved comments for typedmemview * chore: remove duplicate test vector Co-authored-by: James Prestwich <james@prestwi.ch>
Merged
|
@ErinHales this is ready for review |
This was referenced Jul 2, 2020
ErinHales
reviewed
Jul 3, 2020
ErinHales
approved these changes
Jul 3, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking PR for solidity@4.0.0 updates.
BTCViewBTCViewTestsSPVView(TODO: better name)SPVViewTests