Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@prestwich initial attempt to bump crypto deps of
bip32
bip39
core
digest to
0.10
and
k256 to
0.11
hmac
0.12
sha2
0.10
pbkdf2
0.11
which all use digest
0.10
digest 0.10 changed a lot of traits, not 100% sure about migration in core/src/hashes/mod.rs (especially Blake2b256)
there's one failing test in bip32
derived::test::it_can_descendant_sign_and_verify
, which I couldn't make sense of, because if I understood the macros correctlyDerivedXPriv
merely delegates the signer...Also couldn't help myself and ran clippy fix