Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump crypto deps #101

Merged
merged 5 commits into from
Jul 5, 2022
Merged

bump crypto deps #101

merged 5 commits into from
Jul 5, 2022

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jul 5, 2022

@prestwich initial attempt to bump crypto deps of

  • bip32
  • bip39
  • core

digest to 0.10

and
k256 to 0.11
hmac 0.12
sha2 0.10
pbkdf2 0.11
which all use digest 0.10

digest 0.10 changed a lot of traits, not 100% sure about migration in core/src/hashes/mod.rs (especially Blake2b256)

there's one failing test in bip32 derived::test::it_can_descendant_sign_and_verify, which I couldn't make sense of, because if I understood the macros correctly DerivedXPriv merely delegates the signer...

Also couldn't help myself and ran clippy fix

@prestwich
Copy link
Member

the test is failing because the output of the signing function has changed, which should not occur with a version bump unless the signing behavior of ecdsa/k256 has changed 🤔

@prestwich
Copy link
Member

prestwich commented Jul 5, 2022

basically the tests were relying on deterministic signing and had just hardcoded the expected signature. the new signature is still deterministic, but different

@prestwich
Copy link
Member

ah, perusing the changelogs for k256, I'm guessing this is related to an RFC6979 change

RustCrypto/elliptic-curves#552

@mattsse
Copy link
Collaborator Author

mattsse commented Jul 5, 2022

updated hex sig and rsv array

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants