Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handshake Support #43

Merged
merged 55 commits into from
Aug 26, 2020
Merged

Handshake Support #43

merged 55 commits into from
Aug 26, 2020

Conversation

tynes
Copy link
Contributor

@tynes tynes commented Jun 17, 2020

Working on adding a handshake module.

These changes needed to touch the bip32 and core modules as well.

  • Input
  • Output
  • Transaction
  • Encoder
  • Builder
  • Network

Need to revert changes to other modules and address various nits, then this should be good to go

handshake/src/prelude.rs Outdated Show resolved Hide resolved
handshake/src/types/txout.rs Outdated Show resolved Hide resolved
@tynes
Copy link
Contributor Author

tynes commented Jun 29, 2020

Added the covenant field to the output and have some very basic tests. It compiles now, still need to rebase and remove changes to modules other than core.

@tynes
Copy link
Contributor Author

tynes commented Jul 17, 2020

I think that bitcoins/src/enc/bases.rs should be moved to the coins-core crate. I have an almost copy/paste of it included in this PR.

@prestwich
Copy link
Member

unfortunately with the rename a lot of stuff moved around.

I'm fine moving bases to core

@tynes

This comment has been minimized.

@prestwich
Copy link
Member

can we do a core fully generic version and then a specialized wrapper in each crate?

@tynes
Copy link
Contributor Author

tynes commented Jul 17, 2020

I think a thin wrapper over bech32::encode in core that handles common error cases and then wrapping that in each crate with network specifics makes sense.

Cargo.toml Outdated Show resolved Hide resolved
handshake/src/types/tx.rs Outdated Show resolved Hide resolved
handshake/src/types/tx.rs Outdated Show resolved Hide resolved
handshake/src/types/tx.rs Outdated Show resolved Hide resolved
bip32/src/curve/model.rs Outdated Show resolved Hide resolved
handshake/src/prelude.rs Outdated Show resolved Hide resolved
handshake/src/types/mod.rs Outdated Show resolved Hide resolved
handshake/src/types/tx.rs Outdated Show resolved Hide resolved
handshake/src/types/tx.rs Outdated Show resolved Hide resolved
handshake/src/types/tx.rs Outdated Show resolved Hide resolved
handshake/src/types/tx.rs Outdated Show resolved Hide resolved
@tynes
Copy link
Contributor Author

tynes commented Aug 21, 2020

Build failed for unknown reason 🤔

No output has been received in the last 10m0s, this potentially indicates a stalled build or something
wrong with the build itself. Check the details on how to adjust your build configuration on:
https://docs.travis-ci.com/user/common-build-problems/#build-times-out-because-no-output-was-received
The build has been terminated

@prestwich
Copy link
Member

Gonna try restarting it

@prestwich
Copy link
Member

Can you add handshake build and test to the ./build.sh script?

@prestwich prestwich added this to the v1.0.0 milestone Aug 25, 2020
@tynes
Copy link
Contributor Author

tynes commented Aug 26, 2020

Can you add handshake build and test to the ./build.sh script?

#75

Although the build failed again with the same error message

@prestwich prestwich merged commit fa6abe6 into summa-tx:master Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants