Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: fix osx compilation issues #67

Merged
merged 2 commits into from
Aug 18, 2020
Merged

bug: fix osx compilation issues #67

merged 2 commits into from
Aug 18, 2020

Conversation

prestwich
Copy link
Member

I have verified that this succesfully exchanges packets with the device on osx

@prestwich prestwich linked an issue Aug 17, 2020 that may be closed by this pull request
@tynes
Copy link
Contributor

tynes commented Aug 17, 2020

Verified the tests pass and then the tests fail if the ethereum app isn't opened on the ledger.

$ cargo test -- --nocapture
running 1 test
test common::test::serialize ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out


running 2 tests
APDUAnswer: {
	Response: Code 9000 ([APDU_CODE_NOERROR]) 
	Data: Some([2, 1, 2, 11])
}
test exchange ... ok
"IOService:/AppleACPIPlatformExpert/PCI0@0/AppleACPIPCI/XHC1@14/XHC1@14000000/HS01@14100000/Nano S@14100000/Nano S@0/AppleUserUSBHostHIDDevice"
test ledger_device_path ... ok

test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out


running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

Copy link
Contributor

@tynes tynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The app version printed matches the app version installed

@prestwich prestwich merged commit a77b149 into master Aug 18, 2020
@prestwich prestwich deleted the ledger-osx branch August 31, 2020 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ledger native tranport for OSX
2 participants