Allow inplace widget to honor disable_upload setting. #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a fixup for PR lqez#126 commits 4faa7e4 - Ability to enable/disable upload images. That update provided a 'disable_upload' setting which is then honored in the iframe widget, but did not include cooresponding updates for the inplace widget. This commit includes two changes: 1. widget_inplace.html: Mirror the if..endif logic from widget_iframe_editor.html to prevent defining onImageUpload if disable_upload is True. 2. widgets.SummernoteInplaceWidget.render: Mirror the update to views.editor, placing the value of disable_upload in the render context for the inplace widget.
Current coverage is 96.89% (diff: 100%)@@ master #158 diff @@
==========================================
Files 10 10
Lines 193 193
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 187 187
Misses 6 6
Partials 0 0
|
|
Very reasonable. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fixup for PR #126 commits 4faa7e4 - Ability to enable/disable
upload images.
That update provided a 'disable_upload' setting which is then honored
in the iframe widget, but did not include cooresponding updates for the
inplace widget.
This commit includes two changes:
widget_iframe_editor.html to prevent defining onImageUpload if
disable_upload is True.
views.editor, placing the value of disable_upload in the render context
for the inplace widget.