Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes to support more complex values and tags #51

Merged
merged 1 commit into from Mar 30, 2019

Conversation

SerdarSanri
Copy link
Contributor

These changes will comply with summernote documentation. Dev can set what type of tag they would like to use ( div or textarea ) which is also mentioned in original documentation.
Also when there is a complex html content needs to be added as body, having only value as prop makes it very limited. instead using children prop would make it possible to wrap dynamic html content between component tags and pass it along to summernote.

These changes will comply with summernote documentation. Dev can set what type of tag they would like to use ( div or textarea ) which is also mentioned in original documentation. 
Also when there is a complex html content needs to be added as body, having only value as prop makes it very limited. instead using children prop would make it possible to wrap dynamic html content between component tags and pass it along to summernote.
@i-kitaev i-kitaev merged commit 87e545a into summernote:master Mar 30, 2019
@carlosabalde
Copy link

carlosabalde commented Nov 1, 2020

Hi! I'm just a React newbie and perhaps I'm asking something obvious here (sorry!), but I don't know how to init the Summernote component with an HTML value after this change. I mean, I'm aware of dangerouslySetInnerHTML, but I don't want to add an extra parent to the initial editor HTML value. How to use the new children param?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants