Merge 375921b into 9909070

src/js/base/module/Editor.js

@@ -196,9 +196,12 @@ export default class Editor {
       if (this.options.onCreateLink) {
         linkUrl = this.options.onCreateLink(linkUrl);
       } else {
-        // if url doesn't match an URL schema, set http:// as default
-        linkUrl = /^[A-Za-z][A-Za-z0-9+-.]*\:[\/\/]?/.test(linkUrl)
-          ? linkUrl : 'http://' + linkUrl;
+        // if url is not relative,
+        if (!/^\.?\/(.*)/.test(linkUrl)) {
+          // if url doesn't match an URL schema, set http:// as default
+          linkUrl = /^[A-Za-z][A-Za-z0-9+-.]*\:[\/\/]?/.test(linkUrl)
+            ? linkUrl : 'http://' + linkUrl;
+        }
       }
 
       let anchors = [];
@@ -726,8 +729,9 @@ export default class Editor {
       url: $anchor.length ? $anchor.attr('href') : ''
     };
 
-    // Define isNewWindow when anchor exists.
+    // When anchor exists,
     if ($anchor.length) {
+      // Set isNewWindow by checking its target.
       linkInfo.isNewWindow = $anchor.attr('target') === '_blank';
     }
 

src/js/base/module/LinkDialog.js

@@ -80,7 +80,7 @@ export default class LinkDialog {
       const $linkText = this.$dialog.find('.note-link-text');
       const $linkUrl = this.$dialog.find('.note-link-url');
       const $linkBtn = this.$dialog.find('.note-link-btn');
-      const $openInNewWindow = this.$dialog.find('input[type=checkbox]');
+      const $openInNewWindow = this.$dialog.find('#sn-checkbox-open-in-new-window');
 
       this.ui.onDialogShown(this.$dialog, () => {
         this.context.triggerEvent('dialog.shown');
@@ -124,10 +124,10 @@ export default class LinkDialog {
         this.bindEnterKey($linkUrl, $linkBtn);
         this.bindEnterKey($linkText, $linkBtn);
 
-        const isChecked = linkInfo.isNewWindow !== undefined
+        const isNewWindowChecked = linkInfo.isNewWindow !== undefined
           ? linkInfo.isNewWindow : this.context.options.linkTargetBlank;
 
-        $openInNewWindow.prop('checked', isChecked);
+        $openInNewWindow.prop('checked', isNewWindowChecked);
 
         $linkBtn.one('click', (event) => {
           event.preventDefault();

src/js/base/summernote-en-US.js

@@ -54,7 +54,8 @@ $.extend($.summernote.lang, {
       edit: 'Edit',
       textToDisplay: 'Text to display',
       url: 'To what URL should this link go?',
-      openInNewWindow: 'Open in new window'
+      openInNewWindow: 'Open in new window',
+      isRelativeUrl: 'Relative URL'
     },
     table: {
       table: 'Table',

src/js/bs3/settings.js

@@ -109,6 +109,7 @@ $.summernote = $.extend($.summernote, {
     width: null,
     height: null,
     linkTargetBlank: true,
+    linkRelativeUrl: false,
 
     focus: false,
     tabSize: 4,

src/js/bs4/settings.js

@@ -109,6 +109,7 @@ $.summernote = $.extend($.summernote, {
     width: null,
     height: null,
     linkTargetBlank: true,
+    linkRelativeUrl: false,
 
     focus: false,
     tabSize: 4,

src/js/lite/settings.js

@@ -105,6 +105,8 @@ $.summernote = $.extend($.summernote, {
 
     width: null,
     height: null,
+    linkTargetBlank: true,
+    linkRelativeUrl: false,
 
     focus: false,
     tabSize: 4,

src/js/lite/ui.js

@@ -455,7 +455,10 @@ const linkDialog = function(opt) {
       ? '<div class="checkbox">' +
       '<label>' + '<input type="checkbox" checked> ' + opt.lang.link.openInNewWindow + '</label>' +
       '</div>' : ''
-    );
+    ) +
+    '<div class="checkbox">' +
+    '<label>' + '<input type="checkbox" checked> ' + opt.lang.link.isRelativeUrl + '</label>' +
+    '</div>';
   const footer = [
     '<button href="#" type="button" class="note-btn note-btn-primary note-link-btn disabled" disabled>',
     opt.lang.link.insert,

test/unit/base/module/Editor.spec.js

@@ -371,6 +371,26 @@ describe('Editor', () => {
       expectContents(context, '<p><a href="http://summernote.org" target="_blank">summernote</a></p>');
     });
 
+    it('should create a relative link without scheme', () => {
+      var text = 'hello';
+      var editable = context.layoutInfo.editable;
+      var pNode = editable.find('p')[0];
+      var textNode = pNode.childNodes[0];
+      var startIndex = textNode.wholeText.indexOf(text);
+      var endIndex = startIndex + text.length;
+
+      var rng = range.create(textNode, startIndex, textNode, endIndex);
+
+      editor.createLink({
+        url: '/relative/url',
+        text: 'summernote',
+        range: rng,
+        isNewWindow: true
+      });
+
+      expectContents(context, '<p><a href="/relative/url" target="_blank">summernote</a></p>');
+    });
+
     it('should modify a link', () => {
       context.invoke('code', '<p><a href="http://summernote.org">hello world</a></p>');
 

test/unit/base/module/LinkDialog.spec.js

@@ -0,0 +1,56 @@
+/**
+ * LinkDialog.spec.js
+ * (c) 2015~ Summernote Team
+ * summernote may be freely distributed under the MIT license./
+ */
+import chai from 'chai';
+import $ from 'jquery';
+import range from '../../../../src/js/base/core/range';
+import Context from '../../../../src/js/base/Context';
+import LinkDialog from '../../../../src/js/base/module/LinkDialog';
+
+var expect = chai.expect;
+
+describe('bs:module.LinkDialog', () => {
+  var context, dialog, $editable;
+
+  beforeEach(() => {
+    var options = $.extend({}, $.summernote.options);
+    options.langInfo = $.extend(true, {}, $.summernote.lang['en-US'], $.summernote.lang[options.lang]);
+    options.toolbar = [
+      ['insert', ['link']]
+    ];
+    context = new Context(
+      $('<div>' +
+        '<p><a href="https://summernote.org/" target="_blank">hello</a></p>' +
+        '<p><a href="https://summernote.org/">world</a></p>' +
+        '</div>'),
+      options
+    );
+    context.initialize();
+
+    dialog = new LinkDialog(context);
+    dialog.initialize();
+
+    $editable = context.layoutInfo.editable;
+    $editable.appendTo('body');
+  });
+
+  describe('LinkDialog', () => {
+    it('should check new window when target=_blank', () => {
+      range.createFromNode($editable.find('a')[0]).normalize().select();
+      dialog.show();
+
+      var checked = dialog.$dialog.find('#sn-checkbox-open-in-new-window').is(':checked');
+      expect(checked).to.be.true;
+    });
+
+    it('should uncheck new window without target=_blank', () => {
+      range.createFromNode($editable.find('a')[1]).normalize().select();
+      dialog.show();
+
+      var checked = dialog.$dialog.find('#sn-checkbox-open-in-new-window').is(':checked');
+      expect(checked).to.be.false;
+    });
+  });
+});