Merge pull request #3380 from anpaul0615/edit-on-maxtextlength

Edit on maxtextlength
summernote · Oct 26, 2019 · 7edbd1a · 7edbd1a
2 parents a259697 + 1797af5
commit 7edbd1a
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 1 deletion.
diff --git a/src/js/base/core/key.js b/src/js/base/core/key.js
@@ -43,6 +43,12 @@ const KEY_MAP = {
   'LEFTBRACKET': 219,
   'BACKSLASH': 220,
   'RIGHTBRACKET': 221,
+
+  // Navigation
+  'HOME': 36,
+  'END': 35,
+  'PAGEUP': 33,
+  'PAGEDOWN': 34,
 };
 
 /**
@@ -83,6 +89,20 @@ export default {
       KEY_MAP.DOWN,
     ], keyCode);
   },
+  /**
+   * @method isNavigation
+   *
+   * @param {Number} keyCode
+   * @return {Boolean}
+   */
+  isNavigation: (keyCode) => {
+    return lists.contains([
+      KEY_MAP.HOME,
+      KEY_MAP.END,
+      KEY_MAP.PAGEUP,
+      KEY_MAP.PAGEDOWN,
+    ], keyCode);
+  },
   /**
    * @property {Object} nameFromCode
    * @property {String} nameFromCode.8 "BACKSPACE"

diff --git a/src/js/base/module/Editor.js b/src/js/base/module/Editor.js
@@ -343,7 +343,10 @@ export default class Editor {
         }
       }
       if (this.isLimited(1, event)) {
-        return false;
+        const lastRange = this.getLastRange();
+        if (lastRange.eo - lastRange.so === 0) {
+          return false;
+        }
       }
     }).on('keyup', (event) => {
       this.setLastRange();
@@ -447,6 +450,7 @@ export default class Editor {
 
     if (typeof event !== 'undefined') {
       if (key.isMove(event.keyCode) ||
+          key.isNavigation(event.keyCode) ||
           (event.ctrlKey || event.metaKey) ||
           lists.contains([key.code.BACKSPACE, key.code.DELETE], event.keyCode)) {
         return false;