Merge pull request #3359 from summernote/rollback-disableDragAndDrop

Revert "Simply the logic of disableDragAndDrop"
summernote · Aug 15, 2019 · b7fe4f7 · b7fe4f7
2 parents bb6059b + 3854965
commit b7fe4f7
Showing 1 changed file with 11 additions and 5 deletions.
diff --git a/src/js/base/module/Dropzone.js b/src/js/base/module/Dropzone.js
@@ -17,15 +17,21 @@ export default class Dropzone {
     ].join('')).prependTo(this.$editor);
   }
 
-  shouldInitialize() {
-    return !this.options.disableDragAndDrop;
-  }
-
   /**
    * attach Drag and Drop Events
    */
   initialize() {
-    this.attachDragAndDropEvent();
+    if (this.options.disableDragAndDrop) {
+      // prevent default drop event
+      this.documentEventHandlers.onDrop = (e) => {
+        e.preventDefault();
+      };
+      // do not consider outside of dropzone
+      this.$eventListener = this.$dropzone;
+      this.$eventListener.on('drop', this.documentEventHandlers.onDrop);
+    } else {
+      this.attachDragAndDropEvent();
+    }
   }
 
   /**