pasteHTML auto add unused #3370

wzhonggo · 2019-08-21T01:54:46Z

Before submitting an issue, please make sure to search for already open issues, and add to that. This way we can track issues more easily. Thank you, and Thanks for using Summernote.

Description of your Issue or Request:

I want to paste html , but it add many  .

steps to reproduce (Add more if necessary):

go to https://summernote.org/
in chrome console exec $('#summernote').summernote('pasteHTML', '1');
in code view  1  , why has  . Is it has solution not add   when call pasteHTML method

What is your Operating System, Browser and Version and Summernote Version you are using:

This can help find and resolve any issues.

Operating System: Windows 10
Browser and Version: Chrome 76.0.3809.100
Summernote Version: 0.8.12
Bootstrap Version or Lite: bootstrap3

screenshot of issue

Add screenshot which shows your issue(if needed).

You can make gif from Recordit.

If you can make the issue using jsfiddle(https://jsfiddle.net/), We can save time to reproduce the problem.

The text was updated successfully, but these errors were encountered:

DiemenDesign · 2019-09-19T22:58:02Z

Ok, firstly, what you are referring to as "Chrome Console", is not a Console where you can execute commands, it is a source code editor. When you paste things like you are doing, the Summernote API tries to sanitize the input and uses it's best guess, what you are seeing is that guess.

seltix5 · 2019-11-11T19:48:34Z

i'm having the same problem.
example here : https://codepen.io/seltix/pen/qBByJKo

easylogic · 2019-11-20T13:19:43Z

#3495

Budsy · 2019-11-28T07:48:32Z

This is an annoying behavior. If I load in HTML content, then simply save it, it wraps the content in   tags. Repeating loading using htmlPaste and saving with no actions using the editor keeps adding additional tags at the beginning and ending, creating a bigger and bigger file, and basically corrupted content. Has this been addressed? (Using Edge browser and latest build from today). I checked with Chrome and it does the same thing.

DiemenDesign · 2019-11-28T09:15:13Z

Latest build available? or you built the project and used the resulting files from the dist/ folder?

seltix5 · 2019-11-28T09:19:51Z

In my exam le it was with last build available provided by you in another issue.

Budsy · 2019-11-29T17:42:19Z

This was the Bootstrap version that I took from the dist/ folder in the archive.

Budsy · 2019-11-30T18:39:13Z

The workaround for this is to avoid using pasteHTML for loading content. So, when I want to load new content from the server, I first reset and destroy the existing summernote object. Then load the div with the content, then reinitialize a new summernote editor object. This technique works well to leave the content untouched upon loading.

venomoustoad · 2019-12-06T18:41:13Z

@Budsy Could you elaborate in code what you did?

venomoustoad · 2019-12-07T08:05:37Z

Alright, just implemented the workaround based on Budsy's comment using jquery to insert myHTML (a html string). pasteHTML remains broken. Replaces existing summernote with new replica summernote.

<div  id = "summernote_container">
        <div id="summernote" class="summernote">
            <span></span>
        </div>
</div>
<script>
$('#summernote_container').html('<div id="summernote" class="summernote"><span>'+myHTML+'</span></div>');
</script>

Budsy · 2019-12-07T09:19:36Z

I do my content loading with jQuery ajax. Basically, the workaround is to avoid pasteHtml and simply instantiate a new summernote object and load html into the summernote object's content div:

                             $.ajax({
				type: "GET",
				dataType: "html",
				data: { "filePath": fPath }, // fPath tells the handler what content file to fetch.
				url: "/PathToGetHandlerToSendFileContentsAsHtml",
				cache: false,
				success: function (result) {
					$('.summernote').summernote('reset');  // may not be required.
					$('.summernote').summernote('destroy');
					$('.summernote').html(result);
					$('.summernote').summernote();
				},
				error: function (jqXHR, textStatus, errorThrown) {
					alert('There was an error loading the contents file.' + errorThrown);
				}
			});

sigurdne · 2019-12-17T11:18:36Z

pasteHTML works if you set the isNotSplitEdgePoint in the function splitPoint()

//         isNotSplitEdgePoint: isInline
           isNotSplitEdgePoint : true

But I don't know what else it will break...

easylogic · 2019-12-29T05:12:04Z

v0.8.14 is released. please use it.

sigurdne · 2019-12-30T21:14:32Z

This one is still a problem in v0.8.14

The isNotSplitEdgePoint : true fixed it for my use

kotmatpockuh · 2020-02-10T20:17:19Z

Still reproducible.

DiemenDesign · 2020-03-29T03:38:26Z

@easylogic This is still an ongoing issue, I just tried with a curent built from source, and with isNotSplitEdgePoint:true,, the editor when pasting HTML using $("#summernote").summernote('pasteHTML',data); is still adding unwanted   elements to the start and end of every paragraph, which creates an unwanted space before and after each paragraph. I've been looking through the source, and have yet to find a way to stop this being added without breaking things and getting errors.

dreammonkey · 2020-04-06T15:05:41Z

same here, using 0.8.16

dlynam · 2020-05-12T17:50:40Z

Same issue for me in 0.8.16 as well. Also tried downgrading to 0.8.14 and using isNotSplitEdgePoint : true but it puts the first node last when pasting.

davidwaf · 2020-06-07T19:22:18Z

Am using 0.8.18 an experiencing same issue.

Sitheps · 2020-07-09T11:59:44Z

v. 0.8.18 Has any progress been made as to a solution for this very problematic bug?

daveapsgithub · 2020-07-20T22:03:46Z

Out of about 6 HTML Editors, I choose to evaluate summernote first. I slammed straight into this bug. I tried several workarounds. This is the sort of problem that you would expect to see in an alpha release; not something that appears somewhat mature. So I jumped over to https://quilljs.com/ and go it working and integrated in no time at all.

gensablin · 2020-09-12T13:26:19Z

Hi, I played around with this   thing and looks like found the solution.
I used summernote-lite and at line 2129 removed emptyPara: "".concat(blankHTML, ""),
And in summernote-lite.min removed emptyPara:"".concat(j,""),
So editor stopped adding this paragraph.

DiemenDesign · 2020-09-13T02:23:05Z

A PR would be most welcome.

gensablin · 2020-09-13T06:21:27Z

A PR would be most welcome.

It seems that this topic has been of interest to some people for a long time. Can I post this somewhere so it's easy to find? Please tell me where it is better to do it.

DiemenDesign · 2020-09-13T11:42:40Z

I am going to assume you don't have git installed or know how to use it. If you want to post here the functions that you changed I can make the changes, test, and do the PR.

However, if you do know how to clone the repo, make the changes to the file in src/, and do a PR, I'd be more than happy to test the changes and approve the changes as long as the changes don't break other things. If you plan on doing the PR, I urge you to build locally and test as well before doing the PR.

gensablin · 2020-09-14T06:06:30Z

Yes, I'm new to git, never used it, so it will be better if you do all this stuff. But I want to get familiar with git. Some time ago I started a project that I can't seem to handle alone. It's a micro LMS (learning managment system) with a simple constructor for small courses and master classes. I decided to use summernote in this project, so I want this editor to work the way the end user needs.

gensablin · 2020-09-16T18:44:04Z

Oops! It looks like the removal of this emptyPara: "".concat(blankHTML, ""), is affecting summernote('reset');. It stopped working. I decided to change it carefully back, but without , like this emptyPara: "".concat(blankHTML, ""), and reset started working again. In summernote-lite.min - emptyPara:"".concat(j,""),. It seems summernote('reset');. using this blankHTML.

DiemenDesign · 2020-12-05T04:39:41Z

This has been added to the Projects List, you can check the progress here https://github.com/summernote/summernote/projects/3
You can continue to discuss this issue here, but this is marked as closed to make it easier to manage new issues, thank you.

neil-viralmd · 2021-01-14T02:06:02Z

For me, it worked with just this code:

$("#summernote").summernote("destroy");
$("#summernote").html( htmlString );
$("#summernote").summernote();

elementalpete · 2021-07-30T19:17:49Z

The method suggested by a few including neil-viralmd and Budsy didn't work for me, but I got it to work this way:

$("#summernote").summernote("code", htmlString);

FahaoTang · 2022-02-12T22:21:39Z

This issue is also bothering me and the latest release still has this issue. The card in projects has been opened for years. Is there intention to fix it?

nikollaih · 2022-05-03T23:42:12Z

pasteHTML works if you set the isNotSplitEdgePoint in the function splitPoint()
//         isNotSplitEdgePoint: isInline
           isNotSplitEdgePoint : true
But I don't know what else it will break...

@sigurdne It works, thanks

adamjpeterson · 2022-06-09T19:44:33Z

Any updates here? The solutions I'm seeing are for replacing the entire div and not related to the original question of pasting html (pasteHTML) at the cursor position. A paragraph and break are still being added. Any help would be greatly appreciated!

- don't add paragraph if inserting nodes that are not isInline

- update solution to only affect pasteHTML - add doNotInsertPara boolean in insertNode parameter. If true then remove added empty paragraph otherwise only remove the added paragraph if the inserted node is a paragraph (as per original code) - pasteHTML to set doNotInsertPara if the node to be inserted is not an isInline node - revert test change on insertHorizontalRule and insertTable

pasteHTML auto add unused #3370

easylogic mentioned this issue Nov 21, 2019

fixed not using p-br tag #3498

Merged

2 tasks

easylogic closed this as completed Dec 29, 2019

kotmatpockuh mentioned this issue Feb 10, 2020

pasteHTML/insertHtml issue - links are duplicated #3594

Closed

DiemenDesign reopened this Mar 29, 2020

DiemenDesign added Bug Discussion Pull-request-wanted labels Dec 3, 2020

DiemenDesign added this to To do in Bugs Dec 5, 2020

DiemenDesign closed this as completed Dec 5, 2020

alagane mentioned this issue Feb 8, 2022

New lines are added when pasting formatted text on composer linagora/esn-frontend-inbox#523

Open

pandamouse pushed a commit to pandamouse/summernote that referenced this issue Jun 30, 2022

pasteHTML auto add unused summernote#3370

e316efe

- don't add paragraph if inserting nodes that are not isInline

pandamouse mentioned this issue Jun 30, 2022

pasteHTML auto add unused #3370 #4318

Merged

2 tasks

DiemenDesign added a commit that referenced this issue Sep 11, 2022

Merge pull request #4318 from pandamouse/develop

d78698b

pasteHTML auto add unused #3370

DiemenDesign moved this from To do to PR made, Waiting for testing and Approval. in Bugs Feb 1, 2024

DiemenDesign moved this from PR made, Waiting for testing and Approval. to Done in Bugs Feb 1, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

pasteHTML auto add unused <p><br></p> #3370

pasteHTML auto add unused <p><br></p> #3370

wzhonggo commented Aug 21, 2019

DiemenDesign commented Sep 19, 2019 •

edited

seltix5 commented Nov 11, 2019

easylogic commented Nov 20, 2019

Budsy commented Nov 28, 2019 •

edited

DiemenDesign commented Nov 28, 2019

seltix5 commented Nov 28, 2019

Budsy commented Nov 29, 2019

Budsy commented Nov 30, 2019

venomoustoad commented Dec 6, 2019

venomoustoad commented Dec 7, 2019

Budsy commented Dec 7, 2019 •

edited

sigurdne commented Dec 17, 2019

easylogic commented Dec 29, 2019

sigurdne commented Dec 30, 2019

kotmatpockuh commented Feb 10, 2020

DiemenDesign commented Mar 29, 2020 •

edited

dreammonkey commented Apr 6, 2020

dlynam commented May 12, 2020

davidwaf commented Jun 7, 2020

Sitheps commented Jul 9, 2020

daveapsgithub commented Jul 20, 2020

gensablin commented Sep 12, 2020 •

edited

DiemenDesign commented Sep 13, 2020

gensablin commented Sep 13, 2020

DiemenDesign commented Sep 13, 2020

gensablin commented Sep 14, 2020 via email •

edited

gensablin commented Sep 16, 2020

DiemenDesign commented Dec 5, 2020 •

edited

neil-viralmd commented Jan 14, 2021

elementalpete commented Jul 30, 2021

FahaoTang commented Feb 12, 2022

nikollaih commented May 3, 2022

adamjpeterson commented Jun 9, 2022

pasteHTML auto add unused <p><br></p> #3370

pasteHTML auto add unused <p><br></p> #3370

Comments

wzhonggo commented Aug 21, 2019

Description of your Issue or Request:

steps to reproduce (Add more if necessary):

What is your Operating System, Browser and Version and Summernote Version you are using:

screenshot of issue

DiemenDesign commented Sep 19, 2019 • edited

seltix5 commented Nov 11, 2019

easylogic commented Nov 20, 2019

Budsy commented Nov 28, 2019 • edited

DiemenDesign commented Nov 28, 2019

seltix5 commented Nov 28, 2019

Budsy commented Nov 29, 2019

Budsy commented Nov 30, 2019

venomoustoad commented Dec 6, 2019

venomoustoad commented Dec 7, 2019

Budsy commented Dec 7, 2019 • edited

sigurdne commented Dec 17, 2019

easylogic commented Dec 29, 2019

sigurdne commented Dec 30, 2019

kotmatpockuh commented Feb 10, 2020

DiemenDesign commented Mar 29, 2020 • edited

dreammonkey commented Apr 6, 2020

dlynam commented May 12, 2020

davidwaf commented Jun 7, 2020

Sitheps commented Jul 9, 2020

daveapsgithub commented Jul 20, 2020

gensablin commented Sep 12, 2020 • edited

DiemenDesign commented Sep 13, 2020

gensablin commented Sep 13, 2020

DiemenDesign commented Sep 13, 2020

gensablin commented Sep 14, 2020 via email • edited

gensablin commented Sep 16, 2020

DiemenDesign commented Dec 5, 2020 • edited

neil-viralmd commented Jan 14, 2021

elementalpete commented Jul 30, 2021

FahaoTang commented Feb 12, 2022

nikollaih commented May 3, 2022

adamjpeterson commented Jun 9, 2022

DiemenDesign commented Sep 19, 2019 •

edited

Budsy commented Nov 28, 2019 •

edited

Budsy commented Dec 7, 2019 •

edited

DiemenDesign commented Mar 29, 2020 •

edited

gensablin commented Sep 12, 2020 •

edited

gensablin commented Sep 14, 2020 via email •

edited

DiemenDesign commented Dec 5, 2020 •

edited