Select all -> change styling (e.g. font-size) doesn't always walk the entire DOM

[DuncanHouston]

Description of your Issue or Request:

Certain HTML content causes walk() to return early due to nextPointWithEmptyNode() returning null.

steps to reproduce:

1. if you paste the following HTML into the code editor:

<p> First paragraph </p><p> <br> </p><p><a href="https://www.google.com" target="_blank"> LINK </a> <br> </p><p><br></p><p> <u> UNREACHABLE </u> </p>

2. Then select all -> font-size 20, walk() will not process the UNREACHABLE text.

The reason for this is in nextPointWithEmptyNode(): if the current node is the second last child and the next node (last child) is an empty node, as well as the next sibling for the parent being empty, then null is returned and walk() leaves early.

What is your Operating System, Browser and Version and Summernote Version you are using:

This can help find and resolve any issues, place an x inside the brackets or if relevant elaborate after each choice.

1. Operating System:
   [ ] Microsoft Windows
   [X] Apple
   [ ] Linux
   [ ] All

2. Browser and Version:
   [ ] Brave
   [X] Chrome (latest)
   [ ] Edge
   [ ] Firefox
   [ ] Internet Explorer
   [ ] Opera
   [ ] Safari
   [ ] Other (Specify):

3. Summernote Version, place an x inside the brackets:
   [ ] BS3
   [X] BS4
   [ ] Lite
   [ ] All

[DuncanHouston]

I've submitted a pull request #4472, which fixes this. Existing tests pass.

[DennisSuitters]

Thanks just merged the PR, and ran a few different scenarios to check remove what the PR does, doesn't adversely affect other stuff. Thank you.

[MichelleKoolen]

Not sure if this is the issue that appears to be resolved, but when I am for example trying to select the whole text, and I am adjusting the spacing later, suddenly the text appears to be somehow compartmentalized, and after that you can only adjust the font per compartment, as you can see in these screenshots:

[DennisSuitters]

Did you build the project locally from the latest source? Otherwise, you won't have the merged changes. I've asked the other devs in slack about doing the 0.8.20 release (overdue). @lqez @easylogic @hackerwins

[MichelleKoolen]

I asked the team, I also tested it on the summer note website, steps:

I pasted a text from my text editor
added spacing in between with enter
Select all text
select another font

result: one compartment changes

[DennisSuitters]

What team?

Compartment? I think you mean element content, let's get the terminology correct, as it can cause confusion.

The version you're testing on the Summernote website doesn't have the merged changes, which is why I specifically asked about building the project locally. I would test here, but I don't know what browser, OS or which Summernote you're using. I've just tried your steps on my local machine, and it works as expected.

I might be better to create a new issue if you've done the above so we can explore this further.

[MichelleKoolen]

So there is no issue, the summernote version we use is a couple versions behind, thank you for the information because everybody was acting like I was crazy and comparing the issues with the version on the site...