Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dialog templates from body on destroy, using options.dialogsInBody #1179

Merged
merged 1 commit into from Jun 25, 2015

Conversation

mstred
Copy link
Contributor

@mstred mstred commented Jun 25, 2015

What's this PR do?

Where should the reviewer start?

  • src/js/Renderer.js (added conditional function call to remove .note-dialog template div based on options.dialogsInBody definition in summernote's settings)

How should this be manually tested?

  1. In an editor instance, try to execute a destroy() call to summernote;
  2. Assert if the element with dialog templates was properly removed from document.body, as expected to that function behavior

Any background context you want to provide?

This is just a missed code snippet in #1175 PR. Sorry to create another one, folks.

What are the relevant tickets?

#1175

hackerwins added a commit that referenced this pull request Jun 25, 2015
Remove dialog templates from body on destroy, using `options.dialogsInBody`
@hackerwins hackerwins merged commit 235be6e into summernote:develop Jun 25, 2015
@mstred mstred changed the title Remove dialog templates from body on destroy, using options.dialogsInBody Remove dialog templates from body on destroy, using options.dialogsInBody Jun 25, 2015
@mstred
Copy link
Contributor Author

mstred commented Jun 25, 2015

Thanks, @hackerwins.
😄

@hackerwins
Copy link
Member

@mstred 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants