Remove dialog templates from body on destroy, using options.dialogsInBody #1179
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do?
document.body
, when usingoptions.dialogsInBody
attribute as defined in Apply modal dialogs into document.body #1175.Where should the reviewer start?
.note-dialog
template div based onoptions.dialogsInBody
definition in summernote's settings)How should this be manually tested?
destroy()
call to summernote;document.body
, as expected to that function behaviorAny background context you want to provide?
This is just a missed code snippet in #1175 PR. Sorry to create another one, folks.
What are the relevant tickets?
#1175