Update last focus manager#3004
Conversation
|
@easylogic Could you remove |
| @@ -0,0 +1,75 @@ | |||
| import $ from 'jquery'; | |||
There was a problem hiding this comment.
How about to add a credit of @dubiousandrew who created AutoReplace module at first?
|
|
||
| var checked = dialog.$dialog.find('#sn-checkbox-open-in-new-window').is(':checked'); | ||
| expect(checked).to.be.false; | ||
| expect(checked).to.be.true; |
There was a problem hiding this comment.
It does not seem to be related to the commit. strange.
There was a problem hiding this comment.
true is default value to open newWindow in LinkDialog.
checked: true
so test was always fail.
There was a problem hiding this comment.
I modified above code to use createRange in LinkDialog, but I always get an error
| createRange() { | ||
| this.focus(); | ||
| return range.create(this.editable); | ||
| // return range.create(this.editable); |
There was a problem hiding this comment.
I saw that there are many range.create calling at internal and external modules. Is there a chance to use range.create from outside of Editor.js module?
There was a problem hiding this comment.
It would be better to remove comment.
There was a problem hiding this comment.
ok, i will remove comment.
|
Can you tell us when to use getLastRange and createRange respectively? |
|
|
| } | ||
| }); | ||
|
|
||
| import '../summernote'; // eslint-disable-line |
4 participants
What does this PR do?
Where should the reviewer start?
How should this be manually tested?
$(".summernote").summernote("editor.insertText", "aaa")Any background context you want to provide?
What are the relevant tickets?
#33
#2141
#1520
Screenshot (if for frontend)
Checklist