Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add facebook video regex #3087

Merged
merged 1 commit into from
Dec 17, 2018
Merged

Add facebook video regex #3087

merged 1 commit into from
Dec 17, 2018

Conversation

lqez
Copy link
Member

@lqez lqez commented Dec 13, 2018

What does this PR do?

  • Allow Facebook Video URLs

Where should the reviewer start?

  • src/js/base/module/VideoDialog.js

How should this be manually tested?

  • Copy a URL of Facebook Video and put it on Video Dialog.

What are the relevant tickets?

Screenshot (if for frontend)

Nothing special, but let's see Mark of 10 years ago, who was talking about Memcached at FB Tech Talk.
screen shot 2018-12-13 at 5 00 20 pm

Checklist

  • added relevant tests
  • didn't break anything

@lqez lqez self-assigned this Dec 13, 2018
@hackerwins hackerwins added this to the v0.9.0 milestone Dec 13, 2018
@lqez lqez merged commit 2cd066f into develop Dec 17, 2018
@lqez lqez deleted the add-facebook-video branch December 17, 2018 09:07
@hackerwins hackerwins modified the milestones: v0.9.0, v0.8.12 Feb 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants