Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix for custom color issue and add image exception issue. #3416

Merged
merged 2 commits into from Oct 13, 2019

Conversation

reysu47
Copy link
Contributor

@reysu47 reysu47 commented Oct 1, 2019

What does this PR do?

Bug Fix:

  • custom color is not correctly applied to the active editor if there were multiple editors.
  • exception occured while adding an image when there's nothing in editor.

Where should the reviewer start?

How should this be manually tested?

Any background context you want to provide?

What are the relevant tickets?

Screenshot (if for frontend)

Checklist

  • added relevant tests
  • didn't break anything
  • ...

@DennisSuitters DennisSuitters merged commit 2967f27 into summernote:develop Oct 13, 2019
@DennisSuitters
Copy link
Member

Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants