Fix image handle #4283
Merged
Fix image handle #4283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DennisSuitters
pushed a commit
to summernote/skunkworks
that referenced
this pull request
Apr 29, 2022
Fix Handle.js box position as per PR summernote/summernote#4283
DennisSuitters
added
the
Skunked
|
Thanks for your contribution, this was also merged into the Skunkworks Repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Where should the reviewer start?
How should this be manually tested?
See the relevant ticket.
Any background context you want to provide?
Removed the jQuery position() method and replaced it with getBoundingClientRect().
The position() method returned the offset from the table cell and not the editor area.
New code gets position of image and editing area to calculate the offset.
What are the relevant tickets?
Fixes #4242
Checklist