Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pop-up heights have been adjusted to match the content. #4347

Closed
wants to merge 2 commits into from
Closed

Pop-up heights have been adjusted to match the content. #4347

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Sep 13, 2022

What does this PR do?

Resize the popup window according to the content.

Where should the reviewer start?

  • start on the src/styles/lite/scss/modal.scss
// Scale up the modal
@media (min-width: 768px) {
  // Automatically set modal's width for larger viewports
  .note-modal-content {
    width: 600px;
    margin: 30px auto;
    padding-bottom: 30px;
  }
}

How should this be manually tested?

You can test it on the page where the following entities are defined.

  • jquery-3.6.1.min.js
  • bootstrap-5.2.0
  • summernote-0.8.18 (lite)

Checklist

  • Added relevant tests or not required
  • Didn't break anything

@DennisSuitters
Copy link
Member

Have you tested if this affects the other versions of Summernote. If it does then maybe this change should only be made to the BS5 version.

@ghost
Copy link
Author

ghost commented Sep 13, 2022

Have you tested if this affects the other versions of Summernote. If it does then maybe this change should only be made to the BS5 version.

I haven't tested the others.

@DennisSuitters
Copy link
Member

Hi @aliyilmaz I was wondering if you've had time to test this in the other versions of Summernote?

@ghost
Copy link
Author

ghost commented Nov 14, 2022

Hi @aliyilmaz I was wondering if you've had time to test this in the other versions of Summernote?

Hello, unfortunately I did not have the opportunity to try it.

@ghost ghost closed this by deleting the head repository Mar 24, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants