Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add variable to font path #4491

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

rafaeldev
Copy link
Contributor

What does this PR do?

  • Add flexibility to change font serve path

How should this be manually tested?

  • Build and run it

Any background context you want to provide?

This change was motivated by new rails asset pipeline. When we put summernote font to be served from sprockets, the font path can't be reach

Rails.application.config.assets.paths << Rails.root.join("node_modules/summernote/dist/font")

Files start being served from http://localhost:3000/assets/font-name.tff

With this change, we can set the server folder on our scss file, like this:

$sni-font-path: ".";

Thanks!

@DennisSuitters DennisSuitters merged commit 842221f into summernote:develop Jul 10, 2023
2 checks passed
@DennisSuitters
Copy link
Member

Thank you for your contribution. I'm pretty sure there used to be a SASS variable doing the same thing in the past. Not sure why that was changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants