Limit <line> to the text box width #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumpfork
approved these changes
Feb 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
<line>substitution expands to a string of 22 en dash characters, which is 11 ems wide. Any text box narrower than that will cause the<line>to break and overflow onto a second line. TheBodyTextfont is 10 points, so the overflow happens with any text box narrower than 110 points (about 3.88 cm). Accounting for margins, that means that<line>breaks on cards narrower than about 5 cm wide.This PR adds an
emWidthparameter to theadd_inline_textfunction to indicate the available horizontal space in ems. The function then limits the replacement to the number of em dashes that will fit. (The function previously measured in en dashes, which are exactly half the width of an em dash. Changing to em dashes eliminates an extra conversion step.)Fixes #360.