Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make damage bonus part of weapon damage string #106

Closed
Tracked by #497
wake42 opened this issue Dec 21, 2021 · 3 comments · Fixed by #630 or #628
Closed
Tracked by #497

Make damage bonus part of weapon damage string #106

wake42 opened this issue Dec 21, 2021 · 3 comments · Fixed by #630 or #628
Assignees
Labels
🚩 breaking Will need migration script and wiki update type: enhancement Improvement to existing feature. Use "feat: " commit message
Milestone

Comments

@wake42
Copy link
Collaborator

wake42 commented Dec 21, 2021

Original title: Extend weapons model to allow natural weapons without damage-bonus
Duplicate issue Sling Should have Half Damage Bonus

Some natural weapons should not include damage bonus in the damage they make. Figure out a good way to model that in the weapon item data.


Edit:

Implement the possibility to include db in the damage of a weapon, in the same way as damage is presented in the Weapons & Equipment book, for example 1d8+1+db. This also means that the previous "automatic" db must be removed so all weapons in a world must be migrated to get the correct addition to their damage (+db, +db/2 or no damage bonus).

@wake42 wake42 added the type: enhancement Improvement to existing feature. Use "feat: " commit message label Dec 21, 2021
@wake42
Copy link
Collaborator Author

wake42 commented Dec 23, 2021

Some melee weapons also needs 1/2 damage bonus in addition to no Damage bonus!

@wake42
Copy link
Collaborator Author

wake42 commented Dec 23, 2021

A rule anomaly is that some weapons have special rules at a Special Hit. Can be good to have it included .... thinking there might be a feature that shows a text window when hitting Special or crit .... have seen that there are for melee weapons

@wake42 wake42 added this to the release milestone Dec 27, 2021
@wake42 wake42 added the 🚩 breaking Will need migration script and wiki update label Mar 4, 2022
@wake42 wake42 modified the milestones: release, Alpha Release Mar 6, 2022
@wake42 wake42 added this to the 3. Cleanup milestone Mar 19, 2022
@wake42 wake42 modified the milestones: 1.16.0, 1.17.0 Jul 19, 2022
@wake42
Copy link
Collaborator Author

wake42 commented May 25, 2023

Should we introduce a special code db that can be used in the damage field. In weapons&equipment book the damage is specified in the form of 1d4+1+db or 1d6+1+½DB (more natural 1d6+1+db/2). This way you can decide the db per weapon.
Either the Roll code should be extended to fetch the db from the actor (is there a link?) or in the weapon chat code the db part could be replaced with the db, for example if db is 1d4, then 1d6+1+db/2 -> 1d6+1+1d4/2

@wake42 wake42 self-assigned this Sep 30, 2023
@wake42 wake42 changed the title Extend weapons model to allow natural weapons without damage-bonus Make damage bonus part of weapon damage string Oct 2, 2023
wake42 added a commit that referenced this issue Oct 4, 2023
* make damage bonus part of weapon damage string instead of calculated
* modify the descriptive text for missile weapons type
* only allow one of thrown-, projectile- & ranged- weapon flags
* migrate weapon damage to include db
closes #106
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚩 breaking Will need migration script and wiki update type: enhancement Improvement to existing feature. Use "feat: " commit message
Projects
None yet
1 participant