Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve UX of embedding missile weapon & projectiles #154

Closed
Tracked by #282
wake42 opened this issue Jan 4, 2022 · 3 comments
Closed
Tracked by #282

Improve UX of embedding missile weapon & projectiles #154

wake42 opened this issue Jan 4, 2022 · 3 comments
Assignees
Labels
type: enhancement Improvement to existing feature. Use "feat: " commit message type: ux Looks, or usability. Use "feat: " commit message
Milestone

Comments

@wake42
Copy link
Collaborator

wake42 commented Jan 4, 2022

Problem

As it is now when embedding a missile weapon the GM needs to manually open it and connect the wanted arrow items to be able to use the missile weapon. If this could be automated / refactored the UX would be much better.

Suggestions for solving:

When embedding a missile weapon item then show a dialog to connect an available (embedded) projectile. In most cases I think an actor will only have one kind of projectiles, but show a dialog asking which projectile to connect and with an option to not connect any. The reason to not connect could be that one has a javelin (that is a projectile for atlatl) and a self bow. You cannot shoot javelins with a self bow so it should not auto connect them. The same search would have to be done when projectile items are embedded, but this time searching for missile weapons that don't have any specified projectile.
If there is nothing to connect, the dialog should not be shown.

Extra points:

It would be good to have an easy way for the player to switch ammo for a projectile weapon. I imagine adding an option to the right click context menu for missile weapons where one could choose among the available projectiles in a dialog.

Added notes 2022-07-17 Using rqid

Switching to using a rqid to connect the weapon to a projectile would make it possible to create a world weapon item that points to a rqid of a projectile. When that weapon item is embedded in an actor we can search for that rqid in the actor to connect the projectile to the weapon if the projectile also is embedded in the actor.

Final solution

Using rqid was the wrong idea here since you might have two sets of arrows that might have the same rqid. Just display a dropdown with all equipped projectiles. Also show a input field for weapon quantity for projectile & thrown weapons.

@wake42 wake42 added type: enhancement Improvement to existing feature. Use "feat: " commit message type: ux Looks, or usability. Use "feat: " commit message labels Jan 4, 2022
@wake42 wake42 added this to the nice to have milestone Jan 4, 2022
@Moonpile
Copy link
Contributor

Moonpile commented Jan 4, 2022

Does this duplicate or replace #126?

@wake42
Copy link
Collaborator Author

wake42 commented Jan 4, 2022

It does, I'll close #126 I didn't find it when I searched before...

@Moonpile
Copy link
Contributor

See also #492

@wake42 wake42 added the 🚩 breaking Will need migration script and wiki update label May 12, 2023
@wake42 wake42 modified the milestones: 2.3.0, 2.2.0 May 12, 2023
@wake42 wake42 modified the milestones: 2.2.0, 2.3.0 May 25, 2023
@wake42 wake42 modified the milestones: 3.1.0, 3.2.0 Sep 18, 2023
@wake42 wake42 modified the milestones: 3.2.0, 3.3.0 Oct 16, 2023
@wake42 wake42 self-assigned this Nov 8, 2023
@wake42 wake42 removed the 🚩 breaking Will need migration script and wiki update label Nov 9, 2023
@wake42 wake42 closed this as completed in 3c00cf7 Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improvement to existing feature. Use "feat: " commit message type: ux Looks, or usability. Use "feat: " commit message
Projects
None yet
Development

No branches or pull requests

2 participants