Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rqid instead of skillOrigin + skillId on weapon item #290

Closed
Tracked by #282
wake42 opened this issue Jul 17, 2022 · 0 comments · Fixed by #529
Closed
Tracked by #282

Use rqid instead of skillOrigin + skillId on weapon item #290

wake42 opened this issue Jul 17, 2022 · 0 comments · Fixed by #529
Assignees
Labels
🚩 breaking Will need migration script and wiki update type: feature New feature not currently present. Use "feat: " commit message
Milestone

Comments

@wake42
Copy link
Collaborator

wake42 commented Jul 17, 2022

Breaking Refactoring

The currently used two fields skillOrigin & skillId on weapon / usage can be expressed with just one rqid. When the weapon item is embedded in an RqgActor the RqgActor.getEmbeddedItemsByRqid can be used to find the skill that should be used. And if there is no skill a global search for the same rqid could be used to find the skill to embed on the actor (when dragging the weapon to the actor).

Background

The current skillOrigin uses uuid to find the applicable skill, but the uuid can change if the item has been part of a compendium for example. By using rqid this problem is avoided. It will also make the rqid required on the skill to be able to use the skill on a weapon.

@wake42 wake42 added type: feature New feature not currently present. Use "feat: " commit message 🚩 breaking Will need migration script and wiki update labels Jul 17, 2022
@wake42 wake42 added this to the 1.16.0 milestone Jul 17, 2022
@wake42 wake42 mentioned this issue Jul 17, 2022
17 tasks
@wake42 wake42 modified the milestones: 1.16.0, 1.17.0 Jul 19, 2022
@wake42 wake42 modified the milestones: 2.3.0, 2.2.0 Feb 22, 2023
@wake42 wake42 self-assigned this May 11, 2023
@wake42 wake42 closed this as completed in 63e85c6 May 25, 2023
wake42 added a commit that referenced this issue Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚩 breaking Will need migration script and wiki update type: feature New feature not currently present. Use "feat: " commit message
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant