Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rqid for armor coverage #379

Closed
1 task done
Tracked by #282
wake42 opened this issue Sep 23, 2022 · 0 comments
Closed
1 task done
Tracked by #282

Use rqid for armor coverage #379

wake42 opened this issue Sep 23, 2022 · 0 comments
Assignees
Labels
🚩 breaking Will need migration script and wiki update type: enhancement Improvement to existing feature. Use "feat: " commit message
Milestone

Comments

@wake42
Copy link
Collaborator

wake42 commented Sep 23, 2022

Why: Is your feature request related to a problem?

Use Rqid to link protected hitlocations to armor since the hit location name can change depending on language.

What: Describe the solution you'd like

Change hitLocations on the armor item that currently is an array of hitlocation names, to protects that should be an array of hitlocation rqids. The rqid should be used to find embedded hitlocation on the same actor.

Additional context

This will require all hitlocations to have a rqid. Use this format i.hit-location.bodytype-hl-name, that way it will be easy to find all hitlocations for a particular body type with a regex rqid search like await game.system.api.rqid.fromRqidRegexAll(/i.hit-location.humanoid.*/, 'i').

Related issues

@wake42 wake42 added the type: enhancement Improvement to existing feature. Use "feat: " commit message label Sep 23, 2022
@wake42 wake42 mentioned this issue Sep 23, 2022
17 tasks
@wake42 wake42 added this to the 1.21.0 milestone Sep 23, 2022
@wake42 wake42 added the 🚩 breaking Will need migration script and wiki update label Sep 23, 2022
@wake42 wake42 modified the milestones: 3.2.0, 3.3.0 Oct 4, 2023
@wake42 wake42 self-assigned this Nov 10, 2023
@wake42 wake42 closed this as completed in 4f55ef1 Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚩 breaking Will need migration script and wiki update type: enhancement Improvement to existing feature. Use "feat: " commit message
Projects
None yet
Development

No branches or pull requests

1 participant