Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the hitLocation "connectedTo" to use rqid instead #449

Closed
Tracked by #282
wake42 opened this issue Jan 21, 2023 · 0 comments · Fixed by #657
Closed
Tracked by #282

Change the hitLocation "connectedTo" to use rqid instead #449

wake42 opened this issue Jan 21, 2023 · 0 comments · Fixed by #657
Assignees
@wake42
Labels
🚩 breaking Will need migration script and wiki update type: enhancement Improvement to existing feature. Use "feat: " commit message
Milestone
3.3.0 [done]

Comments

@wake42
Copy link
Collaborator

wake42 commented Jan 21, 2023

Why: Is your feature request related to a problem?

Currently the connectedTo property of the hitLocation item contains a name of the hit location it is connected to. This will not work with translation.

What: Describe the solution you'd like

Use an rqid instead and change the property name to attachedTo. The name change is needed to make migration possible.

Additional context

The case #379 should probably be done together.
@wake42 wake42 added type: enhancement Improvement to existing feature. Use "feat: " commit message 🚩 breaking Will need migration script and wiki update labels Jan 21, 2023
@wake42 wake42 mentioned this issue Jan 21, 2023
Open
17 tasks
@wake42 wake42 added this to the 2.3.0 milestone Jan 21, 2023
@wake42 wake42 modified the milestones: 3.2.0, 3.3.0 Oct 4, 2023
@wake42 wake42 closed this as completed in 668dd85 Nov 13, 2023
This was referenced Nov 13, 2023
Closed
Merged
@wake42 wake42 self-assigned this Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wake42 wake42

Labels
🚩 breaking Will need migration script and wiki update type: enhancement Improvement to existing feature. Use "feat: " commit message
Projects
None yet
Milestone
3.3.0 [done]
1 participant
@wake42