Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate AE to foundry 11 #594

Closed
wake42 opened this issue Jul 20, 2023 · 0 comments · Fixed by #600
Closed

Migrate AE to foundry 11 #594

wake42 opened this issue Jul 20, 2023 · 0 comments · Fixed by #600
Assignees
Labels
type: refactor change the implementation - not the behaviour. Use "refactor: " commit message
Milestone

Comments

@wake42
Copy link
Collaborator

wake42 commented Jul 20, 2023

Migrate to Foundry v11

Update the code to follow v11 active effects standards.

original case:

token effect gets re-added when closing actorSheet

What: Describe the bug

A token effect like unconscious gets added again when the actorSheet is closed. Linked tokens seem to work.
Probably related - the token effect is not removed when the wound is healed. Does not work for either linked or unlinked tokens.

It works as expected in Foundry v10

How: To Reproduce

Steps to reproduce the behavior:

  1. Drag an unlinked actor to a scene
  2. Open the actorSheet
  3. Add a wound large enough to inflict a condition (like unconscious or shock)
  4. The effect is added to the token
  5. Close the actorSheet
  6. The effect is duplicated onto the token

Expected behavior

You should only get one instance of the wound effect.

Screenshots

image

Environment - please paste the information from foundry settings tab "support" button:

Foundry v11

@wake42 wake42 added the type: bug Something isn't working. Use "fix: " commit message label Jul 20, 2023
@wake42 wake42 added this to the 2.3.0 milestone Jul 20, 2023
@wake42 wake42 added type: refactor change the implementation - not the behaviour. Use "refactor: " commit message and removed type: bug Something isn't working. Use "fix: " commit message labels Jul 21, 2023
@wake42 wake42 self-assigned this Jul 21, 2023
@wake42 wake42 changed the title token effect gets re-added when closing actorSheet Migrate AE to foundry 11 Jul 22, 2023
@wake42 wake42 closed this as completed in 6511713 Jul 23, 2023
wake42 added a commit that referenced this issue Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: refactor change the implementation - not the behaviour. Use "refactor: " commit message
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant