Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rune type is in Capitals in system but lowercase in wiki #680

Closed
wake42 opened this issue Dec 22, 2023 · 0 comments · Fixed by #678
Closed

Rune type is in Capitals in system but lowercase in wiki #680

wake42 opened this issue Dec 22, 2023 · 0 comments · Fixed by #678
Assignees
@wake42
Labels
type: bug Something isn't working. Use "fix: " commit message
Milestone
3.4.1 [done]

Comments

@wake42
Copy link
Collaborator

wake42 commented Dec 22, 2023

The translation of runetype needs to be the same in the wiki and the system. Currently it's redefined the wiki rqgCompendiumContent.runeType.element but those should be removed and use uiContent.RQG.Item.Rune.RuneType.element instead. The system translations are Capitalized so those should be changed to lower case.

Image
@wake42 wake42 added the type: bug Something isn't working. Use "fix: " commit message label Dec 22, 2023
@wake42 wake42 self-assigned this Dec 22, 2023
@wake42 wake42 added this to the 3.4.1 milestone Dec 22, 2023
wake42 added a commit that referenced this issue Dec 26, 2023
@wake42
fix: rune type is in Capitals in system but lowercase in wiki
fbf1af5 
implements #680
@github-actions github-actions bot mentioned this issue Dec 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wake42 wake42

Labels
type: bug Something isn't working. Use "fix: " commit message
Projects
None yet
Milestone
3.4.1 [done]
Development

Successfully merging a pull request may close this issue.

chore(main): release 3.4.1 sun-dragon-cult/fvtt-system-rqg
1 participant
@wake42