Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it work in modern versions. #14

Merged
merged 2 commits into from
Jan 8, 2019
Merged

Conversation

paper42
Copy link
Contributor

@paper42 paper42 commented Nov 15, 2018

  1. Solves DeprecationWarning in regexes using raw strings.
  2. Solves issue CommonMark Import error #13 - renames module CommonMark to commonmark - CommonMark was an alias, but it was removed in commit 4ee43fbfbc0e3c6f42b8ddb31f2d12cdc3d34c04

@coveralls
Copy link

Pull Request Test Coverage Report for Build 22

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 20: 0.0%
Covered Lines: 533
Relevant Lines: 533

💛 - Coveralls

2 similar comments
@coveralls
Copy link

Pull Request Test Coverage Report for Build 22

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 20: 0.0%
Covered Lines: 533
Relevant Lines: 533

💛 - Coveralls

@coveralls
Copy link

coveralls commented Nov 15, 2018

Pull Request Test Coverage Report for Build 22

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 20: 0.0%
Covered Lines: 533
Relevant Lines: 533

💛 - Coveralls

@paper42 paper42 changed the title Solve DeprecationWarning with raw strings Make it work in modern versions. Nov 15, 2018
@paper42 paper42 mentioned this pull request Nov 15, 2018
@sunainapai sunainapai merged commit b3fb11e into sunainapai:master Jan 8, 2019
@sunainapai
Copy link
Owner

Hi @PaperMountainStudio, Sorry for the delay in merging this pull request. I was away for a while. Thank you for the fixes. I have merged them into master now.

@paper42
Copy link
Contributor Author

paper42 commented Jan 9, 2019

Thanks 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants