Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add normalized search #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add normalized search #19

wants to merge 1 commit into from

Conversation

edi9999
Copy link

@edi9999 edi9999 commented Jan 30, 2017

This makes it possible to find results in lodash docsets by running:

dasht get lodash # this was returning no results before

or

dasht get lo-dash

when the docset name is "Lo-Dash"

This makes it possible to find things in lodash docsets by running:

dasht get lodash # this was returning no results before

or

dasht get lo-dash

when the docset name is "Lo-Dash"
@sunaku
Copy link
Owner

sunaku commented Feb 5, 2017

Interesting, thanks for the pull request. 👍 Let me consider this further because such normalization can be troublesome in some cases. For example, OpenCV_C and OpenCV_C++ would be normalized to the same opencvc name, which isn't helpful when I'm only interested in searching one of them, not both.

@edi9999
Copy link
Author

edi9999 commented Feb 6, 2017

Yes, maybe just not taking into account - and _ would be enough.

@edi9999
Copy link
Author

edi9999 commented May 9, 2017

What do you think of my proposition ?

@sunaku
Copy link
Owner

sunaku commented May 10, 2017

I would prefer fixing the root cause by adding the ability to rename docsets during or after installation. 🛠️

So far, I've been thinking of adding a dasht-docsets-alias script that lets you create symlinks to existing docsets under different names. 💡 But just now, I got an idea for decoupling docset names from their upstream URLs so that we can rename docsets after installation and still be able to update them. 🙃

Stay tuned. 🏃‍♂️

@edi9999
Copy link
Author

edi9999 commented Dec 20, 2017

Just wanted to know if there are any updates on this ?

@sunaku
Copy link
Owner

sunaku commented Dec 21, 2017

I'll try to revisit this during Xmas break. 🎅

@mnewt
Copy link

mnewt commented Nov 5, 2018

@edi9999 Perhaps you could try matching the literal string and if that fails used the normalized version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants