-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add normalized search #19
base: master
Are you sure you want to change the base?
Conversation
This makes it possible to find things in lodash docsets by running: dasht get lodash # this was returning no results before or dasht get lo-dash when the docset name is "Lo-Dash"
Interesting, thanks for the pull request. 👍 Let me consider this further because such normalization can be troublesome in some cases. For example, |
Yes, maybe just not taking into account |
What do you think of my proposition ? |
I would prefer fixing the root cause by adding the ability to rename docsets during or after installation. 🛠️ So far, I've been thinking of adding a Stay tuned. 🏃♂️ |
Just wanted to know if there are any updates on this ? |
I'll try to revisit this during Xmas break. 🎅 |
3c29bad
to
7258767
Compare
@edi9999 Perhaps you could try matching the literal string and if that fails used the normalized version? |
This makes it possible to find results in lodash docsets by running:
dasht get lodash # this was returning no results before
or
dasht get lo-dash
when the docset name is "Lo-Dash"