Upgrade to support 2.8 & 3.0 and fixed deprecations #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trq
force-pushed
the
feature/3.0-compat
branch
2 times, most recently
from
1951265
to
97fd28e
Compare
trq
changed the title
trq
force-pushed
the
feature/3.0-compat
branch
from
97fd28e
to
526b4c8
Compare
| "mobiledetect/mobiledetectlib": "~2.8" | ||
| }, | ||
| "require-dev": { | ||
| "phpunit/phpunit": "~4.1" | ||
| "phpunit/phpunit": "~4.1", | ||
| "symfony/phpunit-bridge": "^3.0" |
There was a problem hiding this comment.
Should be ^2.7|3.0 (3.x requires PHP 5.5.9 or higher).
Closed
|
Hi, I'm trying to use this bundle with Symfony 3.0 but getting errors on composer requirements: My composer.json: Output of |
|
Can't you just check if request_stack exists and get the request from there, otherwise use the 'request' "service"? I think this option is pretty good. $requestStack = $serviceContainer->has('request_stack') ? $serviceContainer->get('request_stack') : null;
if (($requestStack && !$serviceContainer->get('request_stack')->getMasterRequest())
|| false === $serviceContainer->isScopeActive('request')) {
$this->viewType = self::VIEW_NOT_MOBILE;
return;
}
$this->request = $requestStack ? $requestStack->getMasterRequest() : $serviceContainer->get('request');We are using this lib and we don't want to fork it because of this deprecation warning. 😢 @trq Can we agree on a solution? |
|
@suncat2000 Any thoughts on this? I think we should get rid of these deprecation warnings asap as well. |
|
@netmikey I will try on this weekend check it and fix. |
|
Awesome, thx! :) |
Closed
|
any news about this? want to upgrade to 3.0 with this bundle ;) thanks! |
|
sorry guys (@trq, @tsantos84, @arisro, @netmikey, @develth), did not have time to do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All test are passing.