Skip to content
This repository has been archived by the owner on Jan 11, 2021. It is now read-only.

Deploy documentation to github pages #110

Merged
merged 1 commit into from
May 4, 2018
Merged

Deploy documentation to github pages #110

merged 1 commit into from
May 4, 2018

Conversation

sunchao
Copy link
Owner

@sunchao sunchao commented May 3, 2018

No description provided.

@sunchao
Copy link
Owner Author

sunchao commented May 3, 2018

Followed the steps you provided @sadikovi . Can you review this? Thanks!

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 94.851% when pulling 4163cc6 on deploy-docs into 5143db1 on master.

Copy link
Collaborator

@sadikovi sadikovi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

Have you considered adding badges for documentation or update existing links?

@sadikovi
Copy link
Collaborator

sadikovi commented May 4, 2018

Would love to get this merged, so we can close release 0.2.0.

Are we going to release 0.3.0 right after this PR is merged? That would be great, IMHO.

@sunchao
Copy link
Owner Author

sunchao commented May 4, 2018

Thanks @sadikovi . Let me merge this first to see if it works.

Have you considered adding badges for documentation or update existing links?

Will add once this works.

@sunchao sunchao merged commit 19a73e3 into master May 4, 2018
@sadikovi
Copy link
Collaborator

sadikovi commented May 4, 2018

Cheers. You might need to retag 0.2.0 or create a new tag, so it has the latest changes. Can’t wait to see docs!

@sunchao
Copy link
Owner Author

sunchao commented May 4, 2018

Are we going to release 0.3.0 right after this PR is merged? That would be great, IMHO.

Hmm I haven't thought about it. Is that because we want to have the doc cover the latest changes? we can do a 0.2.1 release maybe?

@sadikovi
Copy link
Collaborator

sadikovi commented May 4, 2018

Nah, I was just thinking there were a lot of changes already for 0.3.0. But I am happy either way!

@sunchao sunchao deleted the deploy-docs branch May 4, 2018 06:15
@sunchao
Copy link
Owner Author

sunchao commented May 4, 2018

Cool. I just added a badge for the master branch doc. For some reason, the doc for 0.2.0 didn't show up. Do you have any idea?

@sadikovi
Copy link
Collaborator

sadikovi commented May 4, 2018

It uses old Travis file. You would need to run it on the latest changes. I think that’s why.

@sunchao
Copy link
Owner Author

sunchao commented May 4, 2018

OK I see. So we need to have a new release and then trigger the travis job again. right?

BTW the docs looks really nice. 👍 Thanks @sadikovi for all the work you've done!

@sadikovi
Copy link
Collaborator

sadikovi commented May 4, 2018 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants