-
Notifications
You must be signed in to change notification settings - Fork 19
Conversation
Followed the steps you provided @sadikovi . Can you review this? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks.
Have you considered adding badges for documentation or update existing links?
Would love to get this merged, so we can close release 0.2.0. Are we going to release 0.3.0 right after this PR is merged? That would be great, IMHO. |
Thanks @sadikovi . Let me merge this first to see if it works.
Will add once this works. |
Cheers. You might need to retag 0.2.0 or create a new tag, so it has the latest changes. Can’t wait to see docs! |
Hmm I haven't thought about it. Is that because we want to have the doc cover the latest changes? we can do a 0.2.1 release maybe? |
Nah, I was just thinking there were a lot of changes already for 0.3.0. But I am happy either way! |
Cool. I just added a badge for the master branch doc. For some reason, the doc for 0.2.0 didn't show up. Do you have any idea? |
It uses old Travis file. You would need to run it on the latest changes. I think that’s why. |
OK I see. So we need to have a new release and then trigger the travis job again. right? BTW the docs looks really nice. 👍 Thanks @sadikovi for all the work you've done! |
Probably. It is worth a try.
All good. Happy to help.
…On Fri, 4 May 2018 at 6:22 PM, Chao Sun ***@***.***> wrote:
OK I see. So we need to have a new release and then trigger the travis job
again. right?
BTW the docs looks really nice. 👍 Thanks @sadikovi
<https://github.com/sadikovi> for all the work you've done!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#110 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHbY3sUd93H2cL5F9l46z5urbeyz6Mukks5tu_OegaJpZM4Twl8J>
.
|
No description provided.